Skip to content

bpo-35431: Test math.comb() and math.perm() for OverflowError only on CPython. #14146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Jun 17, 2019
Merged

bpo-35431: Test math.comb() and math.perm() for OverflowError only on CPython. #14146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Lib/test/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ def testFactorialNonIntegers(self):
# Other implementations may place different upper bounds.
@support.cpython_only
def testFactorialHugeInputs(self):
# Currently raises ValueError for inputs that are too large
# Currently raises OverflowError for inputs that are too large
# to fit into a C long.
self.assertRaises(OverflowError, math.factorial, 10**100)
self.assertRaises(OverflowError, math.factorial, 1e100)
Expand Down Expand Up @@ -1917,7 +1917,8 @@ def testPerm(self):
self.assertEqual(perm(n, 0), 1)
self.assertEqual(perm(n, 1), n)
self.assertEqual(perm(n, 2), n * (n-1))
self.assertRaises((OverflowError, MemoryError), perm, n, n)
if support.check_impl_detail(cpython=True):
self.assertRaises(OverflowError, perm, n, n)

for n, k in (True, True), (True, False), (False, False):
self.assertEqual(perm(n, k), 1)
Expand Down Expand Up @@ -1986,7 +1987,8 @@ def testComb(self):
self.assertEqual(comb(n, n), 1)
self.assertEqual(comb(n, n-1), n)
self.assertEqual(comb(n, n-2), n * (n-1) // 2)
self.assertRaises((OverflowError, MemoryError), comb, n, n//2)
if support.check_impl_detail(cpython=True):
self.assertRaises(OverflowError, comb, n, n//2)

for n, k in (True, True), (True, False), (False, False):
self.assertEqual(comb(n, k), 1)
Expand Down