bpo-37468: make install no longer install wininst-*.exe files#14511
bpo-37468: make install no longer install wininst-*.exe files#14511vstinner merged 2 commits intopython:masterfrom vstinner:dont_install_wininst_exe
Conversation
make install no longer installs "wininst-*.exe" files used by distutils bdist_wininst: bdist_wininst only works on Windows.
|
cc @pganssle |
| fi; \ | ||
| done | ||
| @# bpo-37468: Don't install distutils/command/wininst-*.exe files used | ||
| @# by distutils bdist_wininst: bdist_wininst only works on Windows. |
There was a problem hiding this comment.
Should this comment be above line 1436? This for loop does other stuff, right?
There was a problem hiding this comment.
I wasn't sure if it is possible to put comments into this loop which uses \ at end of lines for multiline expression. It looks like it works, so I moved the comment inside the loop.
pganssle
left a comment
There was a problem hiding this comment.
I'm assuming that the Make file can't (or at least isn't intended to) be executed on Windows anyway, then I think this is a good idea.
I had one nitpicky suggestion about where the comment should go, but I don't think I need to withhold approval based on that. @vstinner If you disagree with my suggestion about where the comment should go, feel free to merge.
I don't know how if things like Cygwin or MinGW can build Python using Makefile. I don't know if Cygwin is supported or not (I don't think so). |
I'm no expert in either of those things, but I think that Cygwin is kind of like WSL in that it can and does use |
| *.orig) ;; \ | ||
| # bpo-37468: Don't install distutils/command/wininst-*.exe files used \ | ||
| # by distutils bdist_wininst: bdist_wininst only works on Windows. \ | ||
| *wininst-*.exe) ;; \ |
…GH-14511) make install no longer installs "wininst-*.exe" files used by distutils bdist_wininst: bdist_wininst only works on Windows.
…GH-14511) make install no longer installs "wininst-*.exe" files used by distutils bdist_wininst: bdist_wininst only works on Windows.
make install no longer installs "wininst-*.exe" files used by
distutils bdist_wininst: bdist_wininst only works on Windows.
https://bugs.python.org/issue37468