Fix docstring error in IllegalMonthError and remove dead URL in mro.rst#148924
Fix docstring error in IllegalMonthError and remove dead URL in mro.rst#148924Jah-yee wants to merge 1 commit intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
The documentation was fixed instead in 435be06, please revert your changes. |
| https://doi.org/10.1145/236337.236343 | ||
| .. [#] Guido van Rossum's essay, *Unifying types and classes in Python 2.2*: | ||
| https://web.archive.org/web/20140210194412/http://www.python.org/download/releases/2.2.2/descrintro |
There was a problem hiding this comment.
Isn’t this URL valid and can be opened? The dead URL mentioned in the issue #148909 seems just because that website does not support TLS, but we can visit it via http.
|
I'm sorry but I have to close, neither of the changes are correct. Furthermore, please don't combine two issues into one PR in the future. I suggest you read the devguide, it contains a lot of helpful information on contributing: https://devguide.python.org/ |
Good day
This PR fixes two documentation issues in python/cpython:
IllegalMonthError docstring (
calendar.IllegalMonthErrordocs omit IndexError base class #148663): The docstring incorrectly mentionsIndexErrorbut the code raisesValueError. Updated to reflect the actual exception type.Dead URL in mro.rst (A Dead URL in
mro.rstdoc #148909): Removed a dead URL reference from the mro documentation.Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithRoof
📚 Documentation preview 📚: https://cpython-previews--148924.org.readthedocs.build/