Skip to content

bpo-37759: Second round of edits to Whatsnew 3.8#15204

Merged
rhettinger merged 12 commits intopython:masterfrom
rhettinger:better_whatsnew_round_two
Aug 12, 2019
Merged

bpo-37759: Second round of edits to Whatsnew 3.8#15204
rhettinger merged 12 commits intopython:masterfrom
rhettinger:better_whatsnew_round_two

Conversation

@rhettinger
Copy link
Copy Markdown
Contributor

@rhettinger rhettinger commented Aug 11, 2019 •
edited by bedevere-bot
Loading

Work in progress. Please add suggestions here as you find them.

https://bugs.python.org/issue37759

https://bugs.python.org/issue37759

@rhettinger rhettinger added docs Documentation in the Doc dir skip news labels Aug 11, 2019
@rhettinger rhettinger requested a review from willingc August 12, 2019 05:13
jdemeyer
jdemeyer reviewed Aug 12, 2019
View reviewed changes
Comment thread Doc/whatsnew/3.8.rst Outdated
willingc
willingc approved these changes Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small nit. Thanks @rhettinger.

@rhettinger rhettinger merged commit 66a34d3 into python:master Aug 12, 2019
@rhettinger rhettinger deleted the better_whatsnew_round_two branch August 12, 2019 22:55
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 12, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 12, 2019

Sorry, @rhettinger, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

@rhettinger rhettinger restored the better_whatsnew_round_two branch August 12, 2019 22:56
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 12, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 12, 2019

Sorry @rhettinger, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 12, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 12, 2019

Sorry, @rhettinger, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 13, 2019

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Aug 13, 2019

Sorry @rhettinger, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 66a34d35e4c97da9840a29ba9fba76721021c463 3.8

rhettinger added a commit to rhettinger/cpython that referenced this pull request Aug 13, 2019
@rhettinger
bpo-37759: Second round of edits to Whatsnew 3.8 (pythonGH-15204)
a66d6cc 
(cherry picked from commit 66a34d3)
rhettinger added a commit to rhettinger/cpython that referenced this pull request Aug 13, 2019
@rhettinger
bpo-37759: Second round of edits to Whatsnew 3.8 (pythonGH-15204) (py…
f23b14d 
…thonGH-15240)
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 13, 2019

GH-15240 is a backport of this pull request to the 3.8 branch.

rhettinger added a commit that referenced this pull request Aug 13, 2019
@rhettinger
bpo-37759: Second round of edits to Whatsnew 3.8 (GH-15204) (GH-15240)
9bedb8c 
(cherry picked from commit 66a34d3)
jaraco
jaraco reviewed Sep 2, 2019
View reviewed changes
Comment thread Doc/whatsnew/3.8.rst
>>> version('requests')
'2.22.0'
>>> list(requires('requests'))
['chardet (<3.1.0,>=3.0.2)']
Copy link
Copy Markdown
Member

@jaraco jaraco Sep 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in importlib_metadata 0.19 and earlier (CPython 3.8b3 and earlier) where only the first requirement would be listed. In the latest codebase, backport to 3.8 just rolling out now, the full list appears:

>>> importlib_metadata.requires('requests') 
['chardet (<3.1.0,>=3.0.2)',
 'idna (<2.9,>=2.5)',
 'urllib3 (!=1.25.0,!=1.25.1,<1.26,>=1.21.1)',
 'certifi (>=2017.4.17)',
 "pyOpenSSL (>=0.14) ; extra == 'security'",
 "cryptography (>=1.3.4) ; extra == 'security'",
 "idna (>=2.0.0) ; extra == 'security'",
 "PySocks (!=1.5.7,>=1.5.6) ; extra == 'socks'",
 'win-inet-pton ; (sys_platform == "win32" and python_version == "2.7") and extra == \'socks\'']

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@rhettinger @lisroach
bpo-37759: Second round of edits to Whatsnew 3.8 (pythonGH-15204)
35f83db
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
bpo-37759: Second round of edits to Whatsnew 3.8 (pythonGH-15204)
b42e7b6
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@rhettinger @websurfer5
bpo-37759: Second round of edits to Whatsnew 3.8 (pythonGH-15204)
94900f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco left review comments

@jdemeyer jdemeyer jdemeyer left review comments

@willingc willingc willingc approved these changes

Assignees

@rhettinger rhettinger

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rhettinger @miss-islington @bedevere-bot @jaraco @willingc @jdemeyer @the-knights-who-say-ni