Skip to content

bpo-38378: Rename parameters "out" and "in" of os.sendfile().#16742

Merged
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:os-sendfile-params
Oct 13, 2019
Merged

bpo-38378: Rename parameters "out" and "in" of os.sendfile().#16742
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:os-sendfile-params

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Oct 13, 2019

They conflicted with keyword "in".

Also rename positional-only parameters of private os._fcopyfile()
for consistency.

https://bugs.python.org/issue38378

They conflicted with keyword "in".

Also rename positional-only parameters of private os._fcopyfile()
for consistency.
@serhiy-storchaka serhiy-storchaka merged commit 140a7d1 into python:master Oct 13, 2019
@serhiy-storchaka serhiy-storchaka deleted the os-sendfile-params branch October 13, 2019 08:59
@tirkarthi
Copy link
Copy Markdown
Member

Do we also need to update What's new api changes section for these type of changes?

https://docs.python.org/3.9/whatsnew/3.8.html#changes-in-the-python-api

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
…GH-16742)

They conflicted with keyword "in".

Also rename positional-only parameters of private os._fcopyfile()
for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants