Skip to content

bpo-38525: Fix segfault when using reverse iterators of empty dict literals#16847

Closed
pablogsal wants to merge 1 commit intopython:masterfrom
pablogsal:bpo-38525
Closed

bpo-38525: Fix segfault when using reverse iterators of empty dict literals#16847
pablogsal wants to merge 1 commit intopython:masterfrom
pablogsal:bpo-38525

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Oct 19, 2019 •
edited
Loading

This was a consequence of

commit f2a186712bfe726d54723eba37d80c7f0303a50b
Author: Inada Naoki <[email protected]>
Date:   Tue Mar 12 17:25:44 2019 +0900

    [bpo-30040](https://bugs.python.org/issue30040): new empty dict uses key-sharing dict (GH-1080)
    
    Sizeof new empty dict becomes 72 bytes from 240 bytes (amd64).
    It is same size to empty dict created by dict.clear().

and

commit 6531bf6309c8fda1954060a0fb5ea930b1efb656
Author: Rémi Lapeyre <[email protected]>
Date:   Tue Nov 6 01:38:54 2018 +0100

    [bpo-33462](https://bugs.python.org/issue33462): Add __reversed__ to dict and dict views (GH-6827)

together.

https://bugs.python.org/issue38525

@pablogsal pablogsal requested a review from methane as a code owner October 19, 2019 15:00
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Oct 19, 2019

CC: @remilapeyre

@pablogsal pablogsal self-assigned this Oct 19, 2019
@pablogsal
Copy link
Copy Markdown
Member Author

pablogsal commented Oct 19, 2019

Closing this in favour of #16846

@pablogsal pablogsal closed this Oct 19, 2019
@pablogsal pablogsal deleted the bpo-38525 branch October 19, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane

Assignees

@pablogsal pablogsal

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal @the-knights-who-say-ni @bedevere-bot