bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize#16938
Merged
serhiy-storchaka merged 1 commit intopython:masterfrom Oct 31, 2019
Merged
bpo-38312: Add curses.{get,set}_escdelay and curses.{get,set}_tabsize#16938serhiy-storchaka merged 1 commit intopython:masterfrom
serhiy-storchaka merged 1 commit intopython:masterfrom
Conversation
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please add tests and a What's New entry.
Contributor
Author
For tests I'm not sure it's possible to demonstrate the behaviour -- should I just call the functions and ensure they don't crash? |
Member
|
Yes, testing that functions exist and do not crash is the minimum. Many functions in the curses module do not have better testing. |
8ca65d9 to
0ed9eeb
Compare
Contributor
Author
|
tests and what's new added \o/ -- thanks for the review :) |
0ed9eeb to
7f381b8
Compare
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Add also versionadded to get_escdelay and get_tabsize.
Oh, seems there is no get_tabsize in ncurses. But it is okay.
7f381b8 to
43b90d7
Compare
Contributor
Author
oops! added :) |
serhiy-storchaka
approved these changes
Oct 30, 2019
Member
|
Thanks @asottile! |
Closed
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38312