Skip to content

bpo-38944: Escape key now closes IDLE completion windows.#17419

Merged
terryjreedy merged 5 commits intopython:masterfrom
JohnnyNajera:fix-autocomplete-close-on-escape
Dec 9, 2019
Merged

bpo-38944: Escape key now closes IDLE completion windows.#17419
terryjreedy merged 5 commits intopython:masterfrom
JohnnyNajera:fix-autocomplete-close-on-escape

Conversation

@JohnnyNajera
Copy link
Copy Markdown
Contributor

@JohnnyNajera JohnnyNajera commented Nov 30, 2019 •
edited
Loading

Autocomplete window is not closed on Escape key on some Ubuntu systems. This is because the key press never make it to the event.

https://bugs.python.org/issue38944

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Nov 30, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JohnnyNajera

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JohnnyNajera JohnnyNajera changed the title bop-38944: Fixing Escape key not bound to KeyPress event bpo-38944: Fixing Escape key not bound to KeyPress event Nov 30, 2019
@JohnnyNajera JohnnyNajera force-pushed the fix-autocomplete-close-on-escape branch from 4ac2225 to fa35acf Compare November 30, 2019 12:26
@JohnnyNajera JohnnyNajera changed the title bpo-38944: Fixing Escape key not bound to KeyPress event bpo-38944: Fix Escape key not bound to KeyPress event Dec 3, 2019
@JohnnyNajera
Copy link
Copy Markdown
Contributor Author

JohnnyNajera commented Dec 4, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 4, 2019

Thanks for making the requested changes!

: please review the changes made to this pull request.

@JohnnyNajera JohnnyNajera mentioned this pull request Dec 5, 2019
Merged
terryjreedy
terryjreedy approved these changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge when CI passes.

@terryjreedy terryjreedy added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Dec 9, 2019
@terryjreedy terryjreedy changed the title bpo-38944: Fix Escape key not bound to KeyPress event bpo-38944: Escape key closes IDLE completion windows. Dec 9, 2019
@terryjreedy terryjreedy changed the title bpo-38944: Escape key closes IDLE completion windows. bpo-38944: Escape key now closes IDLE completion windows. Dec 9, 2019
@terryjreedy terryjreedy merged commit 232689b into python:master Dec 9, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 9, 2019

Thanks @JohnnyNajera for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@JohnnyNajera @miss-islington
bpo-38944: Escape key now closes IDLE completion windows. (pythonGH-1…
1f71307 
…7419)

(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 9, 2019

GH-17546 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 9, 2019

GH-17547 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 9, 2019
@JohnnyNajera @miss-islington
bpo-38944: Escape key now closes IDLE completion windows. (pythonGH-1…
9401820 
…7419)

(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <[email protected]>
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @JohnnyNajera
bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
2b2c7bf 
(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <[email protected]>
miss-islington added a commit that referenced this pull request Dec 9, 2019
@miss-islington @JohnnyNajera
bpo-38944: Escape key now closes IDLE completion windows. (GH-17419)
4e0e452 
(cherry picked from commit 232689b)

Co-authored-by: JohnnyNajera <[email protected]>
@python python deleted a comment from bedevere-bot Dec 10, 2019
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Dec 10, 2019

I deleted the report that 2 test_asyncio tests failed on one of the buildbots. This PR cannot be responsible for that.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@JohnnyNajera @shihai1991
bpo-38944: Escape key now closes IDLE completion windows. (pythonGH-1…
063c36a 
…7419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JohnnyNajera @the-knights-who-say-ni @bedevere-bot @miss-islington @terryjreedy