Skip to content

bpo-37404: Fix check for ssl.SSLSocket#17526

Closed
tiran wants to merge 1 commit intopython:masterfrom
tiran:bpo-37404-fix
Closed

bpo-37404: Fix check for ssl.SSLSocket#17526
tiran wants to merge 1 commit intopython:masterfrom
tiran:bpo-37404-fix

Conversation

@tiran
Copy link
Copy Markdown
Member

@tiran tiran commented Dec 9, 2019 •
edited by bedevere-bot
Loading

Fix check for ssl.SSLSocket for Python builds without ssl support. The
check is now performed in debug module only so it does not slow down
production mode.

Fixes: https://bugs.python.org/issue39006
Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue37404

@tiran
bpo-37404: Fix check for ssl.SSLSocket
dbad29a 
Fix check for ssl.SSLSocket for Python builds without ssl support. The
check is now performed in debug module only so it does not slow down
production mode.

Fixes: https://bugs.python.org/issue39006
Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran requested review from 1st1 and asvetlov as code owners December 9, 2019 13:51
@asvetlov
Copy link
Copy Markdown
Contributor

asvetlov commented Dec 9, 2019

@vstinner has another fix for this problem: #17524

I don't know what approach is better, both are satisfactory.
The only thing I want to mention is that I personally prefer to keep checks in release mode as well. In my experience, newbies very rarely run asyncio in debug mode. asyncio is hard enough, better to inform users quickly.
sock_* is an auxiliary API, most programs should use asyncio transports.
Maybe replacement isinstance(sock, ssl.SSLSocket) with type(sock) is ssl.SSLSocket withdraws objections about the performance?

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Dec 9, 2019

I wrote a different fix: PR #17524.

You PR is different: you no longer check if the socket is a SSL socket is non-debug mode.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Dec 9, 2019 •
edited
Loading

@asvetlov: "The only thing I want to mention is that I personally prefer to keep checks in release mode as well."

Ok, so I merged my PR instead, and I close this PR. Thanks @tiran anyway ;-)

@vstinner vstinner closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiran @asvetlov @vstinner @the-knights-who-say-ni @bedevere-bot