@aeros, this will need some help with merging as CI is failing.

@ambv Based on the current build failure message from Travis, it looks like it's probably unrelated to the PR:

$ python --version

Python 3.6.9

$ pip --version

pip 19.3.1 from /home/travis/virtualenv/python3.6.9/lib/python3.6/site-packages/pip (python 3.6)
before_install.1

0.00s$ set -e

$ pyenv global 3.7.1

pyenv: version `3.7.1' not installed

Yes, it's pyenv related. #17579 has a similar problem. So if you want this in 3.8.1, that needs fixing.

@ambv Are you certain that it's an issue we can fix on our end? This seems identical to what @terryjreedy was experiencing a couple of weeks ago in https://mail.python.org/archives/list/[email protected]/thread/YCTLWAYIC44YTVGNN4EDLWKMER2LAPDA/#YCTLWAYIC44YTVGNN4EDLWKMER2LAPDA, which led to Travis CI being temporarily disabled by @brettcannon as a requirement for merging PRs.

@aeros and @ambv: Status check is done, and it's a failure ❌ .

The failure is caused by pyenv so it's not related to the change in this PR. We both agree on that. However, this makes us partially blind (Azure worked) and I would prefer to have CI run successfully before merging to 3.8.

@ambv Oh I see. Sorry about that, I had misunderstood what you meant when you had said "So if you want this in 3.8.1, that needs fixing". I personally don't have experience with pyenv, so I was unsure of the exact cause of the CI failure or what the appropriate fix would be.

In the meantime, I'll work on the What's New entries (for the create_datagram_endpoint() security fix). I should have a PR open for those within the next couple of days.

I'm going to assume I wasn't needed on this and unsubscribe. If I was wrong then just @ mention me again.

This is the same thing I saw before. If Travis is arbitrarily failing again, then it should be unrequired again or really fixed.