Skip to content

bpo-37228: Add whatsnew for removal of loop.create_datagram_endpoint()'s *reuse_address* parameter#17595

Merged
1st1 merged 1 commit intopython:masterfrom
aeros:bpo37228-whatsnew
Dec 16, 2019
Merged

bpo-37228: Add whatsnew for removal of loop.create_datagram_endpoint()'s *reuse_address* parameter#17595
1st1 merged 1 commit intopython:masterfrom
aeros:bpo37228-whatsnew

Conversation

@aeros
Copy link
Copy Markdown
Contributor

@aeros aeros commented Dec 14, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 14, 2019
@aeros aeros requested review from ambv and ned-deily December 14, 2019 02:02
@aeros aeros requested review from 1st1 and asvetlov December 14, 2019 02:05
ned-deily
ned-deily reviewed Dec 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aeros
Copy link
Copy Markdown
Contributor Author

aeros commented Dec 14, 2019 •
edited
Loading

@1st1 and/or @asvetlov, would you mind giving this a final look-over before we add these whatsnews entries? Since it's a backwards incompatible change to asyncio affecting multiple versions (for anyone passing reuse_address=True to loop.create_datagram_endpoint()), I want to make sure we communicate it as well as possible.

Is the current iteration adequate or should it be more specific? My goal was to avoid adding too many details in the whatsnew entry and explain most of it in the documentation.

@1st1 1st1 merged commit f501db2 into python:master Dec 16, 2019
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 16, 2019

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 16, 2019

Thanks @aeros for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8.
🐍🍒⛏🤖

@1st1
Copy link
Copy Markdown
Member

1st1 commented Dec 16, 2019

Thank you, Kyle! Apologies for the wait!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 16, 2019

Sorry, @aeros and @1st1, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f501db2b93a9d3d840b6fb38d6bdda8bcc400d4a 3.8

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 16, 2019

Sorry @aeros and @1st1, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f501db2b93a9d3d840b6fb38d6bdda8bcc400d4a 3.7

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 16, 2019

Sorry, @aeros and @1st1, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f501db2b93a9d3d840b6fb38d6bdda8bcc400d4a 3.6

@1st1
Copy link
Copy Markdown
Member

1st1 commented Dec 16, 2019

@aeros Kyle, could you please manually backport the PR?

@aeros
Copy link
Copy Markdown
Contributor Author

aeros commented Dec 16, 2019

@1st1

Thank you, Kyle! Apologies for the wait!

No problem. (:

Kyle, could you please manually backport the PR?

Yep, and I'll add you as a reviewer for the backports.

aeros added a commit to aeros/cpython that referenced this pull request Dec 16, 2019
@aeros
[3.8] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
71aab00 
…nt()'s *reuse_address* parameter (pythonGH-17595).

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
aeros added a commit to aeros/cpython that referenced this pull request Dec 16, 2019
@aeros
[3.7] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
fa64fb8 
…nt()'s *reuse_address* parameter (pythonGH-17595).

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
aeros added a commit to aeros/cpython that referenced this pull request Dec 16, 2019
@aeros
[3.6] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
3108de9 
…nt()'s *reuse_address* parameter (pythonGH-17595).

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
ned-deily pushed a commit that referenced this pull request Dec 16, 2019
@aeros @ned-deily
[3.6] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
50fc84a 
…nt()'s *reuse_address* parameter (GH-17595). (GH-17632)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
ned-deily pushed a commit that referenced this pull request Dec 17, 2019
@aeros @ned-deily
[3.8] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
a96e938 
…nt()'s *reuse_address* parameter (GH-17595). (#17630)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
ned-deily pushed a commit that referenced this pull request Dec 17, 2019
@aeros @ned-deily
[3.7] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
8a06c9e 
…nt()'s *reuse_address* parameter (GH-17595). (GH-17631)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
@sthagen sthagen mentioned this pull request Dec 17, 2019
Merged
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 18, 2019
@aeros @ned-deily
[3.7] Add whatsnew for removal of asyncio.loop.create_datagram_endpoi…
3413f5c 
…nt()'s *reuse_address* parameter (pythonGH-17595). (pythonGH-17631)

(cherry picked from commit f501db2)

Co-authored-by: Kyle Stanley <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@aeros @shihai1991
Add whatsnew for removal of asyncio.loop.create_datagram_endpoint()'s…
c9c9f35 
… *reuse_address* parameter (python#17595)
farazs-github pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Issue python#17595: MINGW: configure largefile support for windows bu…
59e19ce 
…ilds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily left review comments

@ambv ambv Awaiting requested review from ambv

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

@1st1 1st1

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aeros @bedevere-bot @miss-islington @1st1 @ned-deily @the-knights-who-say-ni