Skip to content

bpo-39121: write gzip header OS information#17682

Closed
wungad wants to merge 1 commit intopython:masterfrom
wungad:write-gzip-os-field
Closed

bpo-39121: write gzip header OS information#17682
wungad wants to merge 1 commit intopython:masterfrom
wungad:write-gzip-os-field

Conversation

@wungad
Copy link
Copy Markdown

@wungad wungad commented Dec 23, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Dec 23, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@wungad

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

corona10
corona10 requested changes Dec 23, 2019
View reviewed changes
Comment thread Misc/ACKS Outdated
Comment thread Misc/NEWS.d/next/Library/2019-12-23-03-21-38.bpo-39121.HgPaAz.rst Outdated
Comment thread Lib/gzip.py Outdated
serhiy-storchaka
serhiy-storchaka reviewed Dec 23, 2019
View reviewed changes
Comment thread Lib/gzip.py Outdated
Comment thread Lib/gzip.py Outdated
Comment thread Lib/gzip.py Outdated
wungad
wungad commented Dec 25, 2019
View reviewed changes
Copy link
Copy Markdown
Author

@wungad wungad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes implemented.

corona10
corona10 reviewed Dec 27, 2019
View reviewed changes
Comment thread Lib/gzip.py Outdated
@csabella csabella requested a review from corona10 May 28, 2020 23:22
corona10
corona10 requested changes May 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wungad

Sorry for the delayed feedback.
Can you rebase your PR?
I will merge it after conflicting is resolved.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 29, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@wungad wungad force-pushed the write-gzip-os-field branch from 9db21eb to 3e6354b Compare May 29, 2020 18:40
@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented May 29, 2020

Sorry, but I do not think we need this feature. There is no any use case. This PR just makes the code more complex without necessity.

@wungad wungad closed this May 29, 2020
@wungad wungad deleted the write-gzip-os-field branch May 29, 2020 22:07
@wungad wungad mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 requested changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wungad @the-knights-who-say-ni @bedevere-bot @serhiy-storchaka @corona10