Skip to content

bpo-22640: Fix function signature of quiet in docs#17719

Merged
pablogsal merged 1 commit intopython:masterfrom
isidentical:bpo-38731
Dec 28, 2019
Merged

bpo-22640: Fix function signature of quiet in docs#17719
pablogsal merged 1 commit intopython:masterfrom
isidentical:bpo-38731

Conversation

@isidentical
Copy link
Copy Markdown
Member

@isidentical isidentical commented Dec 27, 2019 •
edited by bedevere-bot
Loading

just a trivial fix for the signature, i guess this needs backport to 3.8

https://bugs.python.org/issue22640

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 27, 2019
@isidentical isidentical changed the title bpo-38731: Fix function signature of quiet in docs bpo-22640: Fix function signature of quiet in docs Dec 27, 2019
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 28, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pablogsal pablogsal dismissed a stale review December 28, 2019 02:49

I just wanted to comment, not request changes

pablogsal
pablogsal approved these changes Dec 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have to say that quiet being an integer is a bit confusing, but this does not apply to this PR :)

@pablogsal pablogsal merged commit 98f0f04 into python:master Dec 28, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Dec 28, 2019

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 28, 2019

GH-17725 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Dec 28, 2019
@miss-islington @isidentical
bpo-38731: Fix function signature of quiet in docs (GH-17719)
04c1efe 
(cherry picked from commit 98f0f04)

Co-authored-by: Batuhan Taşkaya <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@isidentical @shihai1991
bpo-38731: Fix function signature of quiet in docs (pythonGH-17719)
7d6abd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isidentical @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni