Skip to content

bpo-28707: Add the directory parameter to http.server.SimpleHTTPRequestHandler and http.server module#1776

Merged
vstinner merged 2 commits intopython:masterfrom
matrixise:bpo-28707
May 24, 2017
Merged

bpo-28707: Add the directory parameter to http.server.SimpleHTTPRequestHandler and http.server module#1776
vstinner merged 2 commits intopython:masterfrom
matrixise:bpo-28707

Conversation

@matrixise
Copy link
Copy Markdown
Member

@matrixise matrixise commented May 23, 2017

We can specify a directory when we call http.server as a script with --directory
python -m http.server --directory /tmp

@mention-bot
Copy link
Copy Markdown

mention-bot commented May 23, 2017

@matrixise, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @orsenthil and @benjaminp to be potential reviewers.

vstinner
vstinner approved these changes May 24, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems like tests fail at least on Windows.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 24, 2017

Test failed on Windows (Appveyor):

======================================================================
ERROR: test_windows_colon (test.test_httpservers.SimpleHTTPRequestHandlerTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\cpython\lib\test\test_httpservers.py", line 1079, in test_windows_colon
    path = self.handler.translate_path('c:c:c:foo/filename')
  File "C:\projects\cpython\lib\http\server.py", line 816, in translate_path
    path = self.directory
AttributeError: 'SocketlessRequestHandler' object has no attribute 'directory'
----------------------------------------------------------------------```

vstinner
vstinner approved these changes May 24, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is just a dummy doc warning that has to be fixed.

Comment thread Doc/whatsnew/3.7.rst Outdated
Copy link
Copy Markdown
Member

@vstinner vstinner May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the docs job failed because of a warning on this line.

@vstinner vstinner merged commit a17a2f5 into python:master May 24, 2017
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 24, 2017

test_site failed on AppVeyor. I hopz that it's unrelated ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matrixise @mention-bot @vstinner @the-knights-who-say-ni