bpo-38907: In http.server script, restore binding to IPv4 on Windows.#17851
Merged
jaraco merged 2 commits intopython:masterfrom Jan 6, 2020
jaraco:bugfix/38907-restore-ipv4-bind-windows
Merged
bpo-38907: In http.server script, restore binding to IPv4 on Windows.#17851jaraco merged 2 commits intopython:masterfrom jaraco:bugfix/38907-restore-ipv4-bind-windows
jaraco merged 2 commits intopython:masterfrom
jaraco:bugfix/38907-restore-ipv4-bind-windows
Conversation
Contributor
|
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-17854 is a backport of this pull request to the 3.8 branch. |
Member
Author
|
This change is unsuitable; the call to |
jaraco
added a commit
that referenced
this pull request
Jan 6, 2020
…GH-17851) (#17854) (cherry picked from commit ee94bdb) Co-authored-by: Jason R. Coombs <[email protected]> Co-authored-by: Jason R. Coombs <[email protected]>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes a more surgical approach to GH-17378, addressing only the regression introduced with the dual-stack support added in 3.8 for the
http.servercommand. Presumably, better support will be added to the HTTPServer and TCPServers for dual-stack support in bpo-25667 or bpo-20215, but this PR aims to minimally restore the prior expectation and not affect the behavior of those classes.I considered writing tests for this change, but the existing tests for the
http.servercommand mock out the intended behavior, so I've instead tested the change by applying the patch to Python 3.8.1 on Windows and confirmed it has the intended effect.https://bugs.python.org/issue38907