bpo-39372: Clean header files of declared interfaces with no implementations#18037
bpo-39372: Clean header files of declared interfaces with no implementations#18037pablogsal merged 4 commits intopython:masterfrom
Conversation
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d960460 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, except that the C API section is more appropriate for the NEWS entry.
| typedef PyObject *(*_PyCFunctionFastWithKeywords) (PyObject *, | ||
| PyObject *const *, Py_ssize_t, | ||
| PyObject *); | ||
| typedef PyObject *(*PyNoArgsFunction)(PyObject *); |
There was a problem hiding this comment.
This is the definition. But it is not used, and never was used in CPython, and using it in extensions is likely an indication of an error.
| const char *name /* UTF-8 encoded string */ | ||
| ); | ||
|
|
||
| PyAPI_DATA(PyTypeObject) PyNullImporter_Type; |
There was a problem hiding this comment.
It was implemented in 3.2. Removing the implementation in 3.3 was technically the breakage of the stable ABI. But is too late to fix this.
| @@ -0,0 +1,9 @@ | |||
| Clean header files of interfaces defined but with no implementation. The | |||
| public API symbols being removed are: | |||
|
|
|||
There was a problem hiding this comment.
I afraid that using multi-paragraph news entry can cause problems when files be merged into a single NEWS file.
There was a problem hiding this comment.
Thanks for pointing that out! ... it was too good to be true (I couldn't check at the time I pushed this change).
|
Thanks, Serhiy for the review! |
|
Thank you for your great work! |
…tations (pythonGH-18037) The public API symbols being removed are: _PyBytes_InsertThousandsGroupingLocale, _PyBytes_InsertThousandsGrouping, _Py_InitializeFromArgs, _Py_InitializeFromWideArgs, _PyFloat_Repr, _PyFloat_Digits, _PyFloat_DigitsInit, PyFrame_ExtendStack, _PyAIterWrapper_Type, PyNullImporter_Type, PyCmpWrapper_Type, PySortWrapper_Type, PyNoArgsFunction.
https://bugs.python.org/issue39372