Skip to content

bpo-39424: Fix the call method.#18277

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
damani42:39424-fix_deprecated_regex_method
Jan 30, 2020
Merged

bpo-39424: Fix the call method.#18277
serhiy-storchaka merged 1 commit intopython:masterfrom
damani42:39424-fix_deprecated_regex_method

Conversation

@damani42
Copy link
Copy Markdown
Contributor

@damani42 damani42 commented Jan 30, 2020

The method assertRaisesRegexp is deprecated use assertRaisesRegex
instead.

https://bugs.python.org/issue39424

The method assertRaisesRegexp is deprecated use assertRaisesRegex
instead.
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@damani42

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Copy Markdown
Contributor

@4383 4383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Copy Markdown
Member

@serhiy-storchaka: This change has been merged whereas the CLA was not signed. But it's a trivial change, so I don't think that it matters. Moreover, I'm in touch with @damani42 who told me that he is going to sign the CLA (right me, he didn't get the confirmation email of the creation of his bugs.python.org account).

@serhiy-storchaka
Copy link
Copy Markdown
Member

Yes, I merged it because it was trivial. If not @damani42 somebody other would provide an identical PR in a few days.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants