bpo-39479:Add math.lcm() function: Least Common Multiple by ananthan-123 · Pull Request #18328 · python/cpython

ananthan-123 · 2020-02-03T12:50:24Z

https://bugs.python.org/issue39479

the-knights-who-say-ni · 2020-02-03T12:50:28Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@ananthan-123

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Co-Authored-By: Dong-hee Na <[email protected]>

corona10

Please run make patchcheck and make test before you submit your PR.

bedevere-bot · 2020-02-03T13:56:08Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-Authored-By: Victor Stinner <[email protected]>

ananthan-123 · 2020-02-16T16:59:41Z

Is there any more changes to be made.

ananthan-123 · 2020-02-16T16:59:59Z

I have made the requested changes; please review again

bedevere-bot · 2020-02-16T17:00:04Z

Thanks for making the requested changes!

@serhiy-storchaka, @mdickinson, @vstinner: please review the changes made to this pull request.

mdickinson

Retracting my approval: I didn't notice the most recent doc change (replacing "both" with "nonzero"), and I don't think this change is desirable.

bedevere-bot · 2020-02-16T19:36:57Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ananthan-123 · 2020-02-17T02:37:06Z

I have made the requested changes; please review again

bedevere-bot · 2020-02-17T02:37:12Z

Thanks for making the requested changes!

@serhiy-storchaka, @mdickinson, @vstinner: please review the changes made to this pull request.

ananthan-123 · 2020-02-17T12:20:02Z

Is there any more changes to make.
I have made the requested changes; please review again

bedevere-bot · 2020-02-17T12:20:08Z

Thanks for making the requested changes!

@serhiy-storchaka, @mdickinson, @vstinner: please review the changes made to this pull request.

mdickinson

LGTM. Do you want to add your name to the Misc/ACKS file?

ananthan-123 · 2020-02-18T11:36:13Z

no.

ananthan-123 · 2020-02-18T12:31:39Z

I'm starting a new PR for this as some pro blems caused.
I'm sorry for what happened.
new PR--#18547

ananthan-123 added 4 commits February 3, 2020 17:49

Update 3.9.rst

78c612a

Update math.rst

8300b4e

Update test_math.py

4c215e8

Update mathmodule.c

5ad99af

the-knights-who-say-ni added the CLA not signed label Feb 3, 2020

bedevere-bot added the awaiting review label Feb 3, 2020

ananthan-123 requested review from mdickinson and vstinner February 3, 2020 12:56

corona10 requested changes Feb 3, 2020

View reviewed changes

Comment thread Doc/library/math.rst Outdated

Comment thread Modules/mathmodule.c Outdated

bedevere-bot added awaiting core review and removed awaiting review labels Feb 3, 2020

Update Doc/library/math.rst

c373139

Co-Authored-By: Dong-hee Na <[email protected]>

ananthan-123 requested a review from stevendaprano February 3, 2020 13:23

corona10 requested changes Feb 3, 2020

View reviewed changes

Comment thread Modules/mathmodule.c Outdated

corona10 requested changes Feb 3, 2020

View reviewed changes

Comment thread Lib/test/test_math.py Outdated

vstinner requested changes Feb 3, 2020

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels Feb 3, 2020

ananthan-123 and others added 4 commits February 3, 2020 19:33

Update Doc/library/math.rst

a23ba14

Co-Authored-By: Victor Stinner <[email protected]>

Update Lib/test/test_math.py

b540fc7

Co-Authored-By: Victor Stinner <[email protected]>

Update Doc/library/math.rst

13be573

Co-Authored-By: Victor Stinner <[email protected]>

Update mathmodule.c

a3a36ab

corona10 requested changes Feb 3, 2020

View reviewed changes

corona10 reviewed Feb 3, 2020

View reviewed changes

Comment thread Modules/mathmodule.c Outdated

corona10 reviewed Feb 3, 2020

View reviewed changes

Comment thread Modules/mathmodule.c Outdated

corona10 reviewed Feb 3, 2020

View reviewed changes

Comment thread Modules/mathmodule.c Outdated

ananthan-123 added 2 commits February 3, 2020 21:16

Update test_math.py

34efffa

Update mathmodule.c

e42b00c

bedevere-bot requested review from mdickinson and serhiy-storchaka February 15, 2020 19:04

mdickinson approved these changes Feb 16, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Feb 16, 2020

serhiy-storchaka reviewed Feb 16, 2020

View reviewed changes

Comment thread Doc/library/math.rst

Update math.rst

134c4f4

mdickinson suggested changes Feb 16, 2020

View reviewed changes

Comment thread Doc/library/math.rst Outdated

bedevere-bot added awaiting changes and removed awaiting merge labels Feb 16, 2020

Changed nonzero to both

2db3ca7

bedevere-bot added awaiting change review and removed awaiting changes labels Feb 17, 2020

bedevere-bot requested review from mdickinson and serhiy-storchaka February 17, 2020 02:37

mdickinson approved these changes Feb 17, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Feb 17, 2020

ananthan-123 closed this Feb 18, 2020

ananthan-123 mentioned this pull request Feb 18, 2020

bpo-39479:Add math.lcm() function: Least Common Multiple #18547

Merged

Uh oh!

Conversation

ananthan-123 commented Feb 3, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Feb 3, 2020

CLA Missing

Uh oh!

Uh oh!

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Feb 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ananthan-123 commented Feb 16, 2020

Uh oh!

ananthan-123 commented Feb 16, 2020

Uh oh!

bedevere-bot commented Feb 16, 2020

Uh oh!

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Feb 16, 2020

Uh oh!

ananthan-123 commented Feb 17, 2020

Uh oh!

bedevere-bot commented Feb 17, 2020

Uh oh!

ananthan-123 commented Feb 17, 2020

Uh oh!

bedevere-bot commented Feb 17, 2020

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

ananthan-123 commented Feb 18, 2020

Uh oh!

ananthan-123 commented Feb 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ananthan-123 commented Feb 3, 2020 •

edited by bedevere-bot

Loading