bpo-39479:Add math.lcm() function: Least Common Multiple by ananthan-123 · Pull Request #18547 · python/cpython

ananthan-123 · 2020-02-18T12:29:36Z

https://bugs.python.org/issue39479

ananthan-123 · 2020-02-18T12:33:48Z

This PR is created due to some problems caused in the repository.
#18328

ananthan-123 · 2020-02-18T14:49:30Z

It is showing an error

1 test failed:
test_importlib
Is it because of any changes made by me or not?

mdickinson · 2020-02-18T15:04:35Z

This PR is created due to some problems caused in the repository.

I recommend that you investigate Git branching: instead of making all your commits on the master branch of your fork, create a dedicated branch for the work you're doing, and make the pull request from that. Apart from anything else, that will enable you to work on multiple independent issues at once, in different branches of your fork. See the developer guide for more.

ananthan-123 · 2020-02-18T15:32:46Z

Thanks for the information.
can you tell me what is the problem in the code?

ananthan-123 · 2020-02-18T16:06:04Z

======================================================================
FAIL: test_case_insensitivity (test.test_importlib.extension.test_case_sensitivity.Frozen_ExtensionModuleCaseSensitivityTest)

Traceback (most recent call last):
File "/Users/runner/runners/2.164.0/work/cpython/cpython/Lib/test/test_importlib/extension/test_case_sensitivity.py", line 36, in test_case_insensitivity
self.assertTrue(hasattr(loader, 'load_module'))
AssertionError: False is not true

======================================================================
FAIL: test_case_insensitivity (test.test_importlib.extension.test_case_sensitivity.Source_ExtensionModuleCaseSensitivityTest)

Traceback (most recent call last):
File "/Users/runner/runners/2.164.0/work/cpython/cpython/Lib/test/test_importlib/extension/test_case_sensitivity.py", line 36, in test_case_insensitivity
self.assertTrue(hasattr(loader, 'load_module'))
AssertionError: False is not true

======================================================================
FAIL: test_insensitive (test.test_importlib.source.test_case_sensitivity.Frozen_CaseSensitivityTestPEP302)

Traceback (most recent call last):
File "/Users/runner/runners/2.164.0/work/cpython/cpython/Lib/test/test_importlib/source/test_case_sensitivity.py", line 57, in test_insensitive
self.assertIsNotNone(insensitive)
AssertionError: unexpectedly None

ananthan-123 · 2020-02-18T16:06:40Z

Above is the error showing.

mdickinson

I've left a few comments.

The macOS failures are unrelated, and are described in https://bugs.python.org/issue38691. Once #18553 is merged, you should be able to merge origin/master into your branch to get the CI to pass.

bedevere-bot · 2020-02-18T18:50:38Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot · 2020-02-19T09:54:19Z

Thanks for making the requested changes!

@mdickinson: please review the changes made to this pull request.

mdickinson · 2020-02-19T11:32:27Z

@ananthan-123:

I have made the requested changes

Not quite. :-) Please could you address my comment about alphabetical order in Misc/ACKS?

mdickinson

There's still one unaddressed comment from the last change request.

bedevere-bot · 2020-02-19T11:33:00Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ananthan-123 · 2020-02-19T13:51:51Z

I have made the requested changes; please review again

bedevere-bot · 2020-02-19T13:51:54Z

Thanks for making the requested changes!

@mdickinson: please review the changes made to this pull request.

mdickinson · 2020-02-19T14:23:00Z

@ananthan-123 Please can you investigate the failure on Travis CI? I think you may need to re-run make clinic locally and push the changes that result from that. It would also be worth merging the upstream master into this branch if you haven't already done so.

(As a general rule, it's good to try to get all the CI checks passing before asking for review.)

ananthan-123 · 2020-02-19T17:42:58Z

Hurray!The test is passed

ananthan-123 · 2020-02-19T17:43:38Z

I have made the requested changes; please review again

bedevere-bot · 2020-02-19T17:43:40Z

Thanks for making the requested changes!

@mdickinson: please review the changes made to this pull request.

codecov · 2020-02-19T17:46:45Z

Codecov Report

Merging #18547 into master will increase coverage by 1.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #18547       +/-   ##
===========================================
+ Coverage   82.11%   83.13%    +1.01%     
===========================================
  Files        1956     1571      -385     
  Lines      589382   414787   -174595     
  Branches    44456    44458        +2     
===========================================
- Hits       483979   344832   -139147     
+ Misses      95751    60332    -35419     
+ Partials     9652     9623       -29

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
Lib/test/test_asyncio/test_base_events.py	`91.84% <0.00%> (-3.30%)`	⬇️
... and 431 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d38517...d3edc08. Read the comment docs.

mdickinson

LGTM

bedevere-bot · 2020-02-19T18:21:41Z

@mdickinson: Please replace # with GH- in the commit message next time. Thanks!

ananthan-123 added 7 commits February 18, 2020 17:20

Update math.rst

2a8c0e6

Update math.rst

7b5bbf7

updated whats new

2f64f54

Update test_math.py

e0e5438

Update mathmodule.c

f3aa411

Update mathmodule.c.h

ff27d2f

Update ACKS

b13f01f

the-knights-who-say-ni added the CLA signed label Feb 18, 2020

bedevere-bot added the awaiting review label Feb 18, 2020

ananthan-123 requested a review from mdickinson February 18, 2020 12:29

ananthan-123 mentioned this pull request Feb 18, 2020

bpo-39479:Add math.lcm() function: Least Common Multiple #18328

Closed

📜🤖 Added by blurb_it.

508309d

ananthan-123 requested review from corona10 and serhiy-storchaka February 18, 2020 12:39

ananthan-123 added 2 commits February 18, 2020 18:54

Update 3.9.rst

49f1b4b

Update 2020-02-18-12-37-16.bpo-39479.j3UcCq.rst

cd06d73

mdickinson reviewed Feb 18, 2020

View reviewed changes

Comment thread Doc/library/math.rst Outdated

mdickinson reviewed Feb 18, 2020

View reviewed changes

Comment thread Lib/test/test_math.py Outdated

mdickinson reviewed Feb 18, 2020

View reviewed changes

Comment thread Misc/ACKS Outdated

mdickinson reviewed Feb 18, 2020

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2020-02-18-12-37-16.bpo-39479.j3UcCq.rst Outdated

mdickinson suggested changes Feb 18, 2020

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Feb 18, 2020

bedevere-bot added the awaiting change review label Feb 19, 2020

bedevere-bot requested a review from mdickinson February 19, 2020 09:54

mdickinson suggested changes Feb 19, 2020

View reviewed changes

bedevere-bot removed the awaiting change review label Feb 19, 2020

bedevere-bot added the awaiting changes label Feb 19, 2020

Update ACKS

5e902a1

bedevere-bot added awaiting change review and removed awaiting changes labels Feb 19, 2020

bedevere-bot requested a review from mdickinson February 19, 2020 13:51

ananthan-123 added 4 commits February 19, 2020 20:45

Update mathmodule.c.h

cb0e634

Update mathmodule.c

76bee94

Update mathmodule.c.h

8e3325e

Update mathmodule.c.h

d3edc08

mdickinson approved these changes Feb 19, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Feb 19, 2020

mdickinson merged commit f2ee21d into python:master Feb 19, 2020

bedevere-bot removed the awaiting merge label Feb 19, 2020

Uh oh!

Conversation

ananthan-123 commented Feb 18, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ananthan-123 commented Feb 18, 2020

Uh oh!

ananthan-123 commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdickinson commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ananthan-123 commented Feb 18, 2020

Uh oh!

ananthan-123 commented Feb 18, 2020

====================================================================== FAIL: test_case_insensitivity (test.test_importlib.extension.test_case_sensitivity.Frozen_ExtensionModuleCaseSensitivityTest)

====================================================================== FAIL: test_case_insensitivity (test.test_importlib.extension.test_case_sensitivity.Source_ExtensionModuleCaseSensitivityTest)

====================================================================== FAIL: test_insensitive (test.test_importlib.source.test_case_sensitivity.Frozen_CaseSensitivityTestPEP302)

Uh oh!

ananthan-123 commented Feb 18, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 18, 2020

Uh oh!

bedevere-bot commented Feb 19, 2020

Uh oh!

mdickinson commented Feb 19, 2020

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 19, 2020

Uh oh!

ananthan-123 commented Feb 19, 2020

Uh oh!

bedevere-bot commented Feb 19, 2020

Uh oh!

mdickinson commented Feb 19, 2020

Uh oh!

ananthan-123 commented Feb 19, 2020

Uh oh!

ananthan-123 commented Feb 19, 2020

Uh oh!

bedevere-bot commented Feb 19, 2020

Uh oh!

codecov Bot commented Feb 19, 2020

Codecov Report

Uh oh!

mdickinson left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Feb 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ananthan-123 commented Feb 18, 2020 •

edited by bedevere-bot

Loading

ananthan-123 commented Feb 18, 2020 •

edited

Loading

mdickinson commented Feb 18, 2020 •

edited

Loading

======================================================================
FAIL: test_case_insensitivity (test.test_importlib.extension.test_case_sensitivity.Frozen_ExtensionModuleCaseSensitivityTest)

======================================================================
FAIL: test_case_insensitivity (test.test_importlib.extension.test_case_sensitivity.Source_ExtensionModuleCaseSensitivityTest)

======================================================================
FAIL: test_insensitive (test.test_importlib.source.test_case_sensitivity.Frozen_CaseSensitivityTestPEP302)