Skip to content

bpo-39639: remove suite node#18513

Merged
pablogsal merged 3 commits intopython:masterfrom
isidentical:bpo-39639
Mar 4, 2020
Merged

bpo-39639: remove suite node#18513
pablogsal merged 3 commits intopython:masterfrom
isidentical:bpo-39639

Conversation

@isidentical
Copy link
Copy Markdown
Member

@isidentical isidentical commented Feb 15, 2020

Comment thread Doc/whatsnew/3.9.rst Outdated
@brettcannon
Copy link
Copy Markdown
Member

I haven't touched the AST in a while, so it would be great if someone else can just double-check me. Otherwise, @isidentical , if no other review comes in by Friday just ping me and I will merge this.

Comment thread Misc/NEWS.d/next/Core and Builtins/2020-02-15-15-29-34.bpo-39639.3mqJjm.rst Outdated
Co-Authored-By: Brett Cannon <[email protected]>
Co-Authored-By: Pablo Galindo <[email protected]>
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to change the PR title to " bpo-39639: Remove ast.Suite node class". It can be done when the PR is merged.

Comment thread Parser/Python.asdl
Comment thread Doc/whatsnew/3.9.rst Outdated
Co-Authored-By: Victor Stinner <[email protected]>
Comment thread Misc/NEWS.d/next/Core and Builtins/2020-02-15-15-29-34.bpo-39639.3mqJjm.rst Outdated
@isidentical isidentical requested a review from vstinner March 4, 2020 14:56
@pablogsal pablogsal merged commit d82e469 into python:master Mar 4, 2020
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Mar 4, 2020

@isidentical: Thanks for the doc update, it's now well better ;-) Thanks also for clearing the old dust of from the early age of Python ;)

colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
The AST "Suite" node is no longer used and it can be removed from the ASDL definition and related structures (compiler, visitors, ...).

Co-Authored-By: Victor Stinner <[email protected]>
Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants