Skip to content

bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments.#18604

Merged
mdickinson merged 4 commits intopython:masterfrom
serhiy-storchaka:math-gcd-lcm-multiarg
Feb 23, 2020
Merged

bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments.#18604
mdickinson merged 4 commits intopython:masterfrom
serhiy-storchaka:math-gcd-lcm-multiarg

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Feb 22, 2020 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Feb 22, 2020
@serhiy-storchaka serhiy-storchaka changed the title Expand math.gcd() and math.lcm() to handle multiple arguments. bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. Feb 22, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 22, 2020 •
edited
Loading

Codecov Report

Merging #18604 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18604   +/-   ##
=======================================
  Coverage   82.06%   82.07%           
=======================================
  Files        1955     1955           
  Lines      584068   584073    +5     
  Branches    44458    44459    +1     
=======================================
+ Hits       479334   479353   +19     
+ Misses      95110    95095   -15     
- Partials     9624     9625    +1
Impacted Files Coverage Δ
Lib/idlelib/runscript.py 19.23% <0.00%> (-1.54%) ⬇️
Lib/test/test_random.py 96.78% <0.00%> (-0.31%) ⬇️
Lib/random.py 88.12% <0.00%> (-0.28%) ⬇️
Modules/socketmodule.c 75.78% <0.00%> (+0.08%) ⬆️
Lib/test/test_io.py 94.92% <0.00%> (+0.09%) ⬆️
Lib/test/test_strptime.py 93.80% <0.00%> (+0.22%) ⬆️
Lib/idlelib/editor.py 51.36% <0.00%> (+0.26%) ⬆️
Objects/listobject.c 91.06% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a025d4c...ba9f44a. Read the comment docs.

mdickinson
mdickinson approved these changes Feb 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; a couple of suggested wording tweaks in the documentation.

Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Modules/mathmodule.c
@mdickinson mdickinson merged commit 559e7f1 into python:master Feb 23, 2020
@mdickinson
Copy link
Copy Markdown
Member

mdickinson commented Feb 23, 2020

Thanks, Serhiy!

@mdickinson mdickinson mentioned this pull request Feb 23, 2020
Closed
@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented Feb 23, 2020

Thank you for your review Mark!

@serhiy-storchaka serhiy-storchaka deleted the math-gcd-lcm-multiarg branch February 23, 2020 12:40
@sthagen sthagen mentioned this pull request Feb 23, 2020
Merged
@namannimmo10 namannimmo10 mentioned this pull request Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @mdickinson @the-knights-who-say-ni @bedevere-bot