bpo-36144: Update MappingProxyType with PEP 584's operators#18814
bpo-36144: Update MappingProxyType with PEP 584's operators#18814gvanrossum merged 9 commits intopython:masterfrom
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
Hm, since there's no update() method I think it's better if |= raises an exception as well.
|
Well, I can understand the lack of an My intent here was that the But it's easy enough to change later, if we choose to raise now. I have a slight preference for the way I've written it up, but I'll let you make the call. |
|
If we do raise here, what should the message be? I'd like to at least suggest trying |
|
I really think that it's better to reject I do realize this is a fine line, after all How about this error message: |
No, you've made good points. I too suspect that this will hardly ever be used... and if enough people disagree, it's easy to change it later! |
|
Great!
|
gvanrossum
left a comment
There was a problem hiding this comment.
Yup, that’s good.
I’m not 100% sure that you need to use assertDictEqual—assertEqual is supposed to call it automatically.
|
I want to assert that the return type is |
|
(as opposed to a new MappingProxy or something) |
|
Very good!
|
|
@gvanrossum: Please replace |
bpo-36144: Update MappingProxyType with PEP 584's operators (python#18814)
https://bugs.python.org/issue36144