Fix bpo-30526: Add TextIOWrapper.reconfigure()#1922
Conversation
|
@pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @birkenfeld to be potential reviewers. |
ncoghlan
left a comment
There was a problem hiding this comment.
The actual change mostly looks good to me (just one comment on the specifics of the docs wording).
The commit message should make sure to explain that this doesn't just cover adding reconfigure, it also adds a read-only property to read back the write_through status that was set in either the constructor or the last call to reconfigure().
|
|
||
| Reconfigure this text stream using new values for *line_buffering* | ||
| and *write_through*. Any ``None`` value will keep the current | ||
| value. |
There was a problem hiding this comment.
Rather than using value 3 times, this may be clearer with a mix of setting and argument:
Reconfigure this text stream using new settings for line_buffering and write_through. Passing
Noneas an argument will retain the current setting for that parameter.
That's just a suggestion though, I don't think it's a blocker for merging the patch.
There was a problem hiding this comment.
That's a good suggestion Nick, thank you.
No description provided.