Skip to content

bpo-40192: Use thread_cputime for time.thread_time to improve resolution#19381

Merged
vstinner merged 4 commits intopython:masterfrom
isidentical:bpo-40192
May 16, 2020
Merged

bpo-40192: Use thread_cputime for time.thread_time to improve resolution#19381
vstinner merged 4 commits intopython:masterfrom
isidentical:bpo-40192

Conversation

@isidentical
Copy link
Copy Markdown
Member

@isidentical isidentical commented Apr 5, 2020 •
edited by bedevere-bot
Loading

@isidentical isidentical requested a review from vstinner May 15, 2020 01:22
vstinner
vstinner requested changes May 15, 2020
View reviewed changes
Comment thread Modules/timemodule.c
Comment thread Modules/timemodule.c
Comment thread Modules/timemodule.c Outdated
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 15, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner reviewed May 15, 2020
View reviewed changes
Comment thread Modules/timemodule.c Outdated
Comment thread Doc/whatsnew/3.9.rst Outdated
@isidentical @vstinner
Apply suggestions
a83cf88 
Co-authored-by: Victor Stinner <[email protected]>
@isidentical
Copy link
Copy Markdown
Member Author

isidentical commented May 15, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 15, 2020

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from vstinner May 15, 2020 16:16
@isidentical
Copy link
Copy Markdown
Member Author

isidentical commented May 15, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 15, 2020

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner vstinner merged commit 4541086 into python:master May 16, 2020
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 16, 2020

Merged, thanks @isidentical!

@isidentical
Copy link
Copy Markdown
Member Author

isidentical commented May 16, 2020

Thank you for the review @vstinner!

arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@isidentical @arturoescaip
bpo-40192: Use thread_cputime for time.thread_time to improve resolut…
36a4da0 
…ion (pythonGH-19381)

On AIX, time.thread_time() is now implemented with thread_cputime()
which has nanosecond resolution, rather than
clock_gettime(CLOCK_THREAD_CPUTIME_ID) which has a resolution of 10 ms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkin abalkin Awaiting requested review from abalkin

@pganssle pganssle Awaiting requested review from pganssle

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isidentical @bedevere-bot @vstinner @the-knights-who-say-ni