bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase#19817
Merged
corona10 merged 7 commits intopython:masterfrom May 16, 2020
Merged
bpo-39305: Update nntplib to merge nntplib.NNTP and nntplib._NNTPBase#19817corona10 merged 7 commits intopython:masterfrom
corona10 merged 7 commits intopython:masterfrom
Conversation
Member
Author
|
@vstinner Ready to review! |
Member
Author
|
@vstinner gentle ping |
Member
Author
|
@ericvsmith Would you mind to take a look at this PR? |
Member
Author
|
Can you please take a look also? @warsaw :) |
ericvsmith
reviewed
May 14, 2020
Member
ericvsmith
left a comment
There was a problem hiding this comment.
See my comments. I think it generally looks okay.
corona10
commented
May 16, 2020
Member
Author
There was a problem hiding this comment.
@ericvsmith Thank you Eric, I will merge it after the CI is passed :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39305