[3.8] bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags#21023
Merged
gvanrossum merged 5 commits into3.8from Jun 28, 2020
Merged
[3.8] bpo-35975: Only use cf_feature_version if PyCF_ONLY_AST in cf_flags#21023gvanrossum merged 5 commits into3.8from
gvanrossum merged 5 commits into3.8from
Conversation
pablogsal
approved these changes
Jun 28, 2020
|
@gvanrossum: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stefan Behnel reported that cf_feature_version is used even when
PyCF_ONLY_AST is not set. This is against the intention and against the
documented behavior, so it's been fixed. Includes a test contributed by Stefan.
https://bugs.python.org/issue35975