bpo-43313: support pymalloc for subinterpreters. each subinterpreter ha…#24857
Open
dexterhahaha wants to merge 1 commit intopython:mainfrom
dexterhahaha:fix/pymalloc_subinterpreter
Open
bpo-43313: support pymalloc for subinterpreters. each subinterpreter ha…#24857dexterhahaha wants to merge 1 commit intopython:mainfrom dexterhahaha:fix/pymalloc_subinterpreter
dexterhahaha wants to merge 1 commit intopython:mainfrom
dexterhahaha:fix/pymalloc_subinterpreter
Conversation
Contributor
Author
|
I found the creation and release of the channel object in different interpreters, I will fix it |
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two changes:
support pymalloc for subinterpreters. each subinterpreter has pymalloc_state
_copy_raw_string api alloc memory use PyMem_RawFree and PyMem_RawMalloc.
I extend _xxsubinterpretermodule.c to support call any function in sub interpreter.
when i need return result from sub interpreter call.
i need create item->name in shared item. will use pymem_malloc api to manage memory. when with_pymalloc macro defined, it will create memory and bound to interpreter(iterp1) pymalloc state.
after switch interpreter state, now in iterp2 state, get return value from shareditem, and i need free shared item. but item->name memory managed by interp1 pymalloc state. if i want to free them, i need switch to interpreter state 1. it's complicated.
so i think, in _sharednsitem_init _copy_raw_string, item->name need malloc by PyMem_RawAPI. easy to management.
https://bugs.python.org/issue43313