Skip to content

bpo-38692: Add audit events to pidfd related functions #25515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gousaiyang wants to merge 1 commit into from
Closed

bpo-38692: Add audit events to pidfd related functions #25515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Doc/library/os.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3871,6 +3871,8 @@ written in Python, such as a mail server's external command delivery program.

See the :manpage:`pidfd_open(2)` man page for more details.

.. audit-event:: os.pidfd_open pid,flags os.pidfd_open

.. availability:: Linux 5.3+
.. versionadded:: 3.9

Expand Down
2 changes: 2 additions & 0 deletions Doc/library/signal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ The :mod:`signal` module defines the following functions:

See the :manpage:`pidfd_send_signal(2)` man page for more information.

.. audit-event:: signal.pidfd_send_signal pidfd,sig,siginfo,flags signal.pidfd_send_signal

.. availability:: Linux 5.1+
.. versionadded:: 3.9

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Security/2021-04-21-18-04-12.bpo-38692.Arq9me.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add audit events to :func:`os.pidfd_open` and
:func:`signal.pidfd_send_signal`.
3 changes: 3 additions & 0 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8485,6 +8485,9 @@ static PyObject *
os_pidfd_open_impl(PyObject *module, pid_t pid, unsigned int flags)
/*[clinic end generated code: output=5c7252698947dc41 input=c3fd99ce947ccfef]*/
{
if (PySys_Audit("os.pidfd_open", "iI", pid, flags) < 0) {
return NULL;
}
int fd = syscall(__NR_pidfd_open, pid, flags);
if (fd < 0) {
return posix_error();
Expand Down
4 changes: 4 additions & 0 deletions Modules/signalmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,10 @@ signal_pidfd_send_signal_impl(PyObject *module, int pidfd, int signalnum,
PyErr_SetString(PyExc_TypeError, "siginfo must be None");
return NULL;
}
if (PySys_Audit("signal.pidfd_send_signal", "iiOi", pidfd, signalnum,
siginfo, flags) < 0) {
return NULL;
}
if (syscall(__NR_pidfd_send_signal, pidfd, signalnum, NULL, flags) < 0) {
PyErr_SetFromErrno(PyExc_OSError);
return NULL;
Expand Down