bpo-14965: Proxy `super().x = y` and `del super().x` by habnabit · Pull Request #26194 · python/cpython

habnabit · 2021-05-17T18:38:57Z

Arguably this is a bugfix, and therefore should be backported into the 3.10 branch as well.

This patch was originally contributed by Daniel Urban, whose summary
follows:

I'm attaching a patch implementing super.__setattr__ (and
__delattr__).

The implementation in the patch only works, if super can find a data
descriptor in the MRO, otherwise it throws an AttributeError. As it
can be seen in the tests, in some cases this may result in
counter-intuitive behaviour. But I wasn't able to find another
behaviour, that is consistent with both super.__getattr__ and normal
__setattr__ semantics.

https://bugs.python.org/issue14965

This patch was originally contributed by Daniel Urban, whose summary follows: > I'm attaching a patch implementing super.__setattr__ (and > __delattr__). > The implementation in the patch only works, if super can find a data > descriptor in the MRO, otherwise it throws an AttributeError. As it > can be seen in the tests, in some cases this may result in > counter-intuitive behaviour. But I wasn't able to find another > behaviour, that is consistent with both super.__getattr__ and normal > __setattr__ semantics.

habnabit · 2021-05-17T18:40:19Z

Attaching a NEWS fragment in a moment.

habnabit · 2021-05-17T19:22:41Z

File "/home/runner/work/cpython/cpython/Lib/test/test_doctest.py", line 671, in test.test_doctest.test_DocTestFinder.non_Python_modules
Failed example:
    816 < len(tests) < 836 # approximate number of objects with docstrings

This newly-failing test does appear to be related to the new method super_setattro. I'm not familiar with the new changes to the C API. Does a docstring need to be added to the new super.__setattr__?

habnabit · 2021-05-17T20:06:50Z

#python-dev suggests that this is a coincidental failure and I should increase the numbers from 816 and 836. Should I do that in this change or wait for another PR to bump it?

tiran

The patch looks like Daniel Urban's super_setattr.patch. You cannot take somebody else's code and submit it under your name. Code should be attribute to the original author. We also make sure that Daniel has signed the CLA.

bedevere-bot · 2021-05-17T22:02:49Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

habnabit · 2021-05-17T22:09:09Z

Can you please explain how you’d like me to attribute it? The original author’s name is listed in the NEWS fragment and the commit message already.

…

On Mon, May 17, 2021 at 23:03 Christian Heimes ***@***.***> wrote: ***@***.**** requested changes on this pull request. The patch looks like Daniel Urban's super_setattr.patch. You cannot take somebody else's code and submit it under your name. Code should be attribute to the original author. We also make sure that Daniel has signed the CLA. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#26194 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFFMCRTHPUED5TKOKKDDTTOGHBXANCNFSM45A7Y27A> .

habnabit · 2021-05-17T22:13:19Z

In fact, I neither want nor need my name on this in the first place. This patch has been sitting stale since 2012 without movement.

…

On Mon, May 17, 2021 at 23:08 hab ***@***.***> wrote: Can you please explain how you’d like me to attribute it? The original author’s name is listed in the NEWS fragment and the commit message already. On Mon, May 17, 2021 at 23:03 Christian Heimes ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > The patch looks like Daniel Urban's super_setattr.patch. You cannot take > somebody else's code and submit it under your name. Code should be > attribute to the original author. We also make sure that Daniel has signed > the CLA. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#26194 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAFFMCRTHPUED5TKOKKDDTTOGHBXANCNFSM45A7Y27A> > . >

habnabit · 2021-05-28T13:03:09Z

@tiran Daniel Urban claims on bpo-14965 that they've already signed a contributor agreement. What's the next step?

github-actions · 2021-06-28T00:06:19Z

This PR is stale because it has been open for 30 days with no activity.

SwooshyCueb · 2021-12-02T16:30:07Z

What's the next step here? How can we get this merged?

python-cla-bot · 2025-04-06T14:31:52Z

All commit authors signed the Contributor License Agreement.

habnabit · 2025-04-07T22:35:26Z

Really? I'm sure I signed the CLA years ago; I've had patches merged before.

habnabit · 2025-04-07T22:36:35Z

Well, signed again now. Looks like there's another merge conflict. Will anything happen if I actually update the patch?

SwooshyCueb · 2025-04-08T17:02:14Z

Well, signed again now. Looks like there's another merge conflict. Will anything happen if I actually update the patch?

I've already updated the patch here: #29950

If you update this one, I assume recent discussion will move here from the new one.

(ignore my previous response, I thought you were commenting on my PR instead of yours)

github-actions · 2026-04-09T06:31:33Z

This PR is stale because it has been open for 30 days with no activity.

habnabit requested a review from markshannon as a code owner May 17, 2021 18:38

bedevere-bot added the awaiting review label May 17, 2021

the-knights-who-say-ni added the CLA signed label May 17, 2021

📜🤖 Added by blurb_it.

8178379

tiran requested changes May 17, 2021

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels May 17, 2021

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jun 28, 2021

SwooshyCueb mentioned this pull request Dec 7, 2021

bpo-14965: Proxy super().x = y and del super().x (updated) #29950

Open

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 8, 2022

ghost mentioned this pull request Apr 10, 2022

super() and property inheritance behavior #59170

Open

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 9, 2026

Uh oh!

Conversation

habnabit commented May 17, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

habnabit commented May 17, 2021

Uh oh!

habnabit commented May 17, 2021

Uh oh!

habnabit commented May 17, 2021

Uh oh!

tiran left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented May 17, 2021

Uh oh!

habnabit commented May 17, 2021 via email

Uh oh!

habnabit commented May 17, 2021 via email

Uh oh!

habnabit commented May 28, 2021

Uh oh!

github-actions Bot commented Jun 28, 2021

Uh oh!

SwooshyCueb commented Dec 2, 2021

Uh oh!

python-cla-bot Bot commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

habnabit commented Apr 7, 2025 via email

Uh oh!

habnabit commented Apr 7, 2025

Uh oh!

SwooshyCueb commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

habnabit commented May 17, 2021 •

edited by bedevere-bot

Loading

python-cla-bot Bot commented Apr 6, 2025 •

edited

Loading