Skip to content

bpo-44309: Add support for yescrypt in crypt.#26526

Closed
besser82 wants to merge 3 commits intopython:mainfrom
besser82:topic/besser82/cryptmodule_yescrypt
Closed

bpo-44309: Add support for yescrypt in crypt.#26526
besser82 wants to merge 3 commits intopython:mainfrom
besser82:topic/besser82/cryptmodule_yescrypt

Conversation

@besser82
Copy link
Copy Markdown

@besser82 besser82 commented Jun 4, 2021

Proposed PR adds support for a new method in the crypt module:

yescrypt. It is considered stronger as SHA512 or blowfish and as strong as argon2 for crypt() purpose. The hashing method was developed by the author of the blowfish crypt method, and was based on scrypt. It is supported on most Linux distributions, that ship with libxcrypt as a replacement for the glibc crypt library: Fedora, Debian, Ubuntu, OpenSUSE and many others.

https://bugs.python.org/issue44309

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@besser82

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@besser82 besser82 changed the title bpo-31664: Add support for yescrypt in crypt. bpo-44309: Add support for yescrypt in crypt. Jun 4, 2021
@besser82 besser82 force-pushed the topic/besser82/cryptmodule_yescrypt branch 5 times, most recently from be75e6d to e70e534 Compare June 4, 2021 20:14
Comment thread Lib/crypt.py Outdated
@serhiy-storchaka serhiy-storchaka requested a review from tiran June 5, 2021 09:39
@tiran
Copy link
Copy Markdown
Member

tiran commented Jun 5, 2021

I left a comment on bpo that explains why I'm against this feature.

@besser82 besser82 force-pushed the topic/besser82/cryptmodule_yescrypt branch from a9ab912 to baefd10 Compare June 24, 2021 23:00
@besser82 besser82 force-pushed the topic/besser82/cryptmodule_yescrypt branch from baefd10 to 72e0009 Compare July 22, 2021 22:48
@AlexWaygood
Copy link
Copy Markdown
Member

@besser82, many thanks for your PR. Unfortunately, the crypt module is now deprecated following the acceptance of PEP 594 by the Steering Council; as such, CPython will no longer be accepting bugfixes or improvements to this module. I am therefore closing this PR.

I hope that this does not dissuade you from contributing to CPython in the future 🙂

@besser82 besser82 mannequin mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants