Skip to content

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag#26680

Merged
nanjekyejoannah merged 1 commit intopython:mainfrom
erlend-aasland:remove-duplicate-ssl-flag
Jun 12, 2021
Merged

bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag#26680
nanjekyejoannah merged 1 commit intopython:mainfrom
erlend-aasland:remove-duplicate-ssl-flag

Conversation

@erlend-aasland
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, @tiran can confirm on this.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @nanjekyejoannah! I figure this is just a copy-and-paste error.

Copy link
Copy Markdown
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let me merge this. Christian can complain, if it was not meant to be.

@nanjekyejoannah nanjekyejoannah merged commit cb7230c into python:main Jun 12, 2021
@erlend-aasland erlend-aasland deleted the remove-duplicate-ssl-flag branch June 12, 2021 20:18
@tiran tiran added the needs backport to 3.10 only security fixes label Jun 13, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2021
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 13, 2021
@bedevere-bot
Copy link
Copy Markdown

GH-26704 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jun 13, 2021
(cherry picked from commit cb7230c)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants