bpo-44652: Preserve natural order of args in the union type.#27185
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom Jul 16, 2021
Merged
bpo-44652: Preserve natural order of args in the union type.#27185serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka merged 2 commits intopython:mainfrom
Conversation
Member
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM. Just one comment below.
| check((str | int) | (int | list), (str, int, list)) | ||
| check((str | int) | typing.Union[int, list], (str, int, list)) | ||
| check(typing.Union[str, int] | (int | list), (str, int, list)) | ||
| return |
Member
Author
There was a problem hiding this comment.
Good catch! I forgot to remove it.
| PyObject* i_element = PyTuple_GET_ITEM(args, i); | ||
| for (Py_ssize_t j = i + 1; j < arg_length; j++) { | ||
| PyObject* j_element = PyTuple_GET_ITEM(args, j); | ||
| for (Py_ssize_t j = 0; j < added_items; j++) { |
Member
There was a problem hiding this comment.
Just noticed this should be faster too (for a small number of unique members :).
Fidget-Spinner
approved these changes
Jul 16, 2021
Member
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LG. Windows azure pipelines test_asyncio is failing which is unrelated.
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Sorry @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jul 16, 2021
…ythonGH-27185) (cherry picked from commit 0cd2d51) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-27190 is a backport of this pull request to the 3.10 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44652