bpo-45886: Allow overriding freeze command for cross compiling (GH-29735)#29735
Merged
tiran merged 1 commit intopython:mainfrom Nov 24, 2021
Merged
bpo-45886: Allow overriding freeze command for cross compiling (GH-29735)#29735tiran merged 1 commit intopython:mainfrom
tiran merged 1 commit intopython:mainfrom
Conversation
``` ../../configure -C --host=aarch64-linux-gnu-gcc --build=x86_64-pc-linux-gnu make FREEZE_MODULE=../x86_64/Program/_freeze_module ``` Signed-off-by: Christian Heimes <[email protected]>
Member
Author
|
gvanrossum
approved these changes
Nov 23, 2021
| # END: freezing modules | ||
|
|
||
| Tools/scripts/freeze_modules.py: Programs/_freeze_module | ||
| Tools/scripts/freeze_modules.py: $(FREEZE_MODULE) |
Member
There was a problem hiding this comment.
I guess when Make sees a reference to something outside the tree it's just going to take it at face value, assuming it exists at all? What's the failure mode if that file doesn't exist?
Member
Author
There was a problem hiding this comment.
Our Makefile does not specify a build rule for the target $(FREEZE_MODULE). There is only a build rule for Programs/_freeze_module. If FREEZE_MODULE points to a different, non-existing file then make complains and stops:
$ make regen-deepfreeze FREEZE_MODULE=builddep/origin/Programs/invalid
make: *** No rule to make target 'builddep/origin/Programs/invalid', needed by 'Python/frozen_modules/importlib._bootstrap.h'. Stop.
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue45886