bpo-46341: remove duplicate paragraphs in asyncio documentation#30526
bpo-46341: remove duplicate paragraphs in asyncio documentation#30526davem14 wants to merge 1 commit intopython:3.10from
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
asvetlov
left a comment
There was a problem hiding this comment.
The change is visible to the end user.
Please create an issue on https://bugs.python.org first.
Otherwise looks good.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
|
If you change the title of your PR to "bpo-46341: remove duplicate paragraphs in asyncio documentation", the bots will automatically link this PR to your BPO issue and turn the CI green :) |
|
Btw, you've also used the 3.10 branch as the base for this PR — changes to CPython are nearly always made to the |
|
So, what should I do now? |
|
Closing the PR and refiling against the main branch might be the easiest solution, I'm afraid :/ feel free to ping me if you do so, and I'll add the skip-news label to your new PR 🙂 you can obviously link your new PR to the same BPO ticket. Also, as an aside, it would be great if you could sign the CLA, if you haven't already. It's not necessary for very small/trivial changes, but for legal reasons CPython can't accept significant contributions from people who haven't signed the CLA 🙂 |
https://bugs.python.org/issue46341