bpo-2604: Make DocTestCase reset globs in teardown#31932
Merged
JelleZijlstra merged 3 commits intopython:mainfrom Mar 22, 2022
Merged
bpo-2604: Make DocTestCase reset globs in teardown#31932JelleZijlstra merged 3 commits intopython:mainfrom
JelleZijlstra merged 3 commits intopython:mainfrom
Conversation
Co-authored-by: Piet Delport Co-authored-by: Hugo Lopes Tavares
Member
|
Thanks! I think this does need a news entry because doctest is a public API and this fixes a user-visible bug. |
Contributor
Author
|
@JelleZijlstra Added 😄 Not sure if that also means that this needs to be back ported, but I'll leave that decision up to you. |
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Mar 19, 2022
Contributor
|
Thanks @DanielNoord for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Contributor
|
Sorry @DanielNoord and @JelleZijlstra, I had trouble checking out the |
|
GH-32057 is a backport of this pull request to the 3.9 branch. |
Contributor
|
Thanks @DanielNoord for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-32058 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 22, 2022
…31932) Co-authored-by: Piet Delport Co-authored-by: Hugo Lopes Tavares Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 7ba7eae) Co-authored-by: Daniël van Noord <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 22, 2022
…31932) Co-authored-by: Piet Delport Co-authored-by: Hugo Lopes Tavares Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 7ba7eae) Co-authored-by: Daniël van Noord <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 22, 2022
Co-authored-by: Piet Delport Co-authored-by: Hugo Lopes Tavares Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 7ba7eae) Co-authored-by: Daniël van Noord <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 22, 2022
Co-authored-by: Piet Delport Co-authored-by: Hugo Lopes Tavares Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 7ba7eae) Co-authored-by: Daniël van Noord <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…31932) Co-authored-by: Piet Delport Co-authored-by: Hugo Lopes Tavares Co-authored-by: Jelle Zijlstra <[email protected]> (cherry picked from commit 7ba7eae) Co-authored-by: Daniël van Noord <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets bpo-2604 and bpo-9736.
Combination of both patches as suggested by Irit Katriel on bpo-2604.
I didn't include a news entry as I didn't think it was necessary for test changes. Let me know if I should add one!
https://bugs.python.org/issue2604