bpo-47196: Fix function pointer cast in test_imp#32244
Merged
miss-islington merged 2 commits intopython:mainfrom Apr 2, 2022
Merged
bpo-47196: Fix function pointer cast in test_imp#32244miss-islington merged 2 commits intopython:mainfrom
miss-islington merged 2 commits intopython:mainfrom
Conversation
The function PyInit_imp_dummy is declared as void f(PyObject* spec) but called as void f(void). On wasm targets without the call trampolines this causes a fatal error.
tiran
approved these changes
Apr 2, 2022
Member
tiran
left a comment
There was a problem hiding this comment.
Looks correct to me. All other modules have an init function without an argument (grep -R -A1 PyMODINIT_FUNC Modules/).
Contributor
|
@hoodmane: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function PyInit_imp_dummy is declared as void f(PyObject* spec)
but called as void f(void). On wasm targets without the call
trampolines this causes a fatal error.
https://bugs.python.org/issue47196
Automerge-Triggered-By: GH:tiran