Skip to content

bpo-31337 Close a minor NULL dereference opportunity #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
warsaw wants to merge 5 commits into from
Closed

bpo-31337 Close a minor NULL dereference opportunity #3282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9dc577a
Watch out for NULL return.
warsaw Aug 30, 2017
bc4634d
Add a blurb entry for the issue.
warsaw Sep 4, 2017
f7e3c40
Typo in blurb entry.
warsaw Sep 4, 2017
6696c23
Merge branch 'master' into compile-null-ptr
warsaw Sep 4, 2017
4600bcf
Set an appropriate exception.
warsaw Sep 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2017-09-04-09-51-53.bpo-31337.CSt-e_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Close a minor NULL dereference opportunity in compile.c. Found by Kirit
Sankar Gupta.
5 changes: 5 additions & 0 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3360,6 +3360,11 @@ compiler_subdict(struct compiler *c, expr_ty e, Py_ssize_t begin, Py_ssize_t end
}
for (i = begin; i < end; i++) {
key = get_const_value((expr_ty)asdl_seq_GET(e->v.Dict.keys, i));
if (key == NULL) {
Py_DECREF(keys);
PyErr_BadInternalCall();
return 0;
}
Py_INCREF(key);
PyTuple_SET_ITEM(keys, i - begin, key);
}
Expand Down