Skip to content

[2.7] bpo-30450: Don't use where, it doesn't exist on XP#3330

Merged
zware merged 1 commit intopython:2.7from
zware:xp_you_annoy_me
Sep 5, 2017
Merged

[2.7] bpo-30450: Don't use where, it doesn't exist on XP#3330
zware merged 1 commit intopython:2.7from
zware:xp_you_annoy_me

Conversation

@zware
Copy link
Copy Markdown
Member

@zware zware commented Sep 4, 2017

@zware zware requested a review from zooba September 4, 2017 23:38
@vstinner vstinner changed the title Don't use where, it doesn't exist on XP [2.7] Don't use where, it doesn't exist on XP Sep 5, 2017
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even if I don't know Windows error codes :-)

@zooba
Copy link
Copy Markdown
Member

zooba commented Sep 5, 2017

Do builds on XP even work? I thought we supported it as a target, but not a build OS.

@vstinner vstinner changed the title [2.7] Don't use where, it doesn't exist on XP [2.7] bpo-30450: Don't use where, it doesn't exist on XP Sep 5, 2017
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Sep 5, 2017

Don't skip the issue, if there is an issue :-) https://bugs.python.org/issue30450

@zware
Copy link
Copy Markdown
Member Author

zware commented Sep 5, 2017

@zware zware merged commit aa23144 into python:2.7 Sep 5, 2017
@zware zware deleted the xp_you_annoy_me branch September 5, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants