Skip to content

bpo-27319, bpo-31508: Document deprecation in Treeview.selection().#3667

Merged
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:treeview-selection-deprecate
Sep 24, 2017
Merged

bpo-27319, bpo-31508: Document deprecation in Treeview.selection().#3667
serhiy-storchaka merged 2 commits intopython:masterfrom
serhiy-storchaka:treeview-selection-deprecate

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented Sep 20, 2017 •
edited by bedevere-bot
Loading

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.

https://bugs.python.org/issue27319

@serhiy-storchaka
bpo-27319, bpo-31508: Document deprecation in Treeview.selection().
af8bec5 
Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir tests Tests in the Lib/test dir labels Sep 20, 2017
vstinner
vstinner approved these changes Sep 20, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It's up to you to apply this one or PR #3651.

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented Sep 20, 2017

@terryjreedy, could you please make a review of the documentation changes?

I don't think documenting this in the "What's New" document is required. This is minor change. And I hope nobody uses selection('add', items) instead of selection_add(items).

vadmium
vadmium reviewed Sep 20, 2017
View reviewed changes
Comment thread Doc/library/tkinter.ttk.rst Outdated
*items* becomes the new selection.

.. versionchanged:: 3.6
*items* can be passeed as separate arguments, not just as a single tuple.
Copy link
Copy Markdown
Member

@vadmium vadmium Sep 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed with a single E

Copy link
Copy Markdown
Member Author

@serhiy-storchaka serhiy-storchaka Sep 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@terryjreedy terryjreedy mentioned this pull request Sep 21, 2017
Merged
@terryjreedy
Copy link
Copy Markdown
Member

terryjreedy commented Sep 21, 2017

Items being either singular or plural is slightly awkward. I would leave what you have as is. Martin knows the markup better than I. I would push this now and #3651 after 3.7 is branched off after the beta.

@serhiy-storchaka serhiy-storchaka merged commit 2fad102 into python:master Sep 24, 2017
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Sep 24, 2017

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the treeview-selection-deprecate branch September 24, 2017 11:34
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Sep 24, 2017

GH-3719 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2017
@serhiy-storchaka @miss-islington
[3.6] bpo-27319, bpo-31508: Document deprecation in Treeview.selectio…
1d8502c 
…n(). (pythonGH-3667)

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
(cherry picked from commit 2fad102)
serhiy-storchaka pushed a commit that referenced this pull request Sep 24, 2017
@miss-islington @serhiy-storchaka
[3.6] bpo-27319, bpo-31508: Document deprecation in Treeview.selectio…
e31eca4 
…n(). (GH-3667) (#3719)

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
(cherry picked from commit 2fad102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmium vadmium vadmium left review comments

@vstinner vstinner vstinner approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-storchaka @terryjreedy @miss-islington @bedevere-bot @vstinner @vadmium @Mariatta @the-knights-who-say-ni