Skip to content

bpo-25351: avoid activate failure on strict shells#3804

Merged
vsajip merged 1 commit intopython:masterfrom
ssbarnea:master
Sep 29, 2017
Merged

bpo-25351: avoid activate failure on strict shells#3804
vsajip merged 1 commit intopython:masterfrom
ssbarnea:master

Conversation

@ssbarnea
Copy link
Copy Markdown
Contributor

@ssbarnea ssbarnea commented Sep 28, 2017

Allows usage of activate on strict shells (set -uoe pipefail)

https://bugs.python.org/issue25351

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ssbarnea ssbarnea changed the title avoid activate failure on strict shells (#25351) bpo-25351: avoid activate failure on strict shells Sep 28, 2017
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @ssbarnea for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-3820 is a backport of this pull request to the 3.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants