bpo-31638: Add compression support to zipapp#3819
Conversation
Add optional argument `compressed` to `zipapp.create_archive`, and add option `--compress` to the command line interface of `zipapp`.
|
Looks good to me. I'm actually tempted to consider defaulting to uncompressed as a bug, and simply switch to compressing by default. (When I implemented this, I never even considered that uncompressed was the default for @brettcannon what's your view on this? The only compatibility issue I can see would be for Pythons built without zlib support. Is that something we'd need to consider? And if so, would having an |
|
The module needs to work with zlib not existing and it should default to uncompressed. I don't view adding a single boolean argument to a call burdensome if it makes people think about the trade-offs of compatibility and decompression overhead versus download/disk size. |
|
OK, cool. Thanks for the clarification. |
|
Thanks for the contribution, @zmwangx! |
|
Thanks for the quick turnaround! |
Add optional argument
compressedtozipapp.create_archive, and add option--compressto the command line interface ofzipapp.https://bugs.python.org/issue31638