bpo-31778: Make ast.literal_eval() more strict.#4035
Merged
serhiy-storchaka merged 4 commits intopython:masterfrom Jan 4, 2018
Merged
bpo-31778: Make ast.literal_eval() more strict.#4035serhiy-storchaka merged 4 commits intopython:masterfrom
serhiy-storchaka merged 4 commits intopython:masterfrom
Conversation
Addition and subtraction of arbitrary numbers no longer allowed.
dbieber
approved these changes
Nov 9, 2017
dbieber
left a comment
There was a problem hiding this comment.
This looks good to me. Two test suggestions inline.
I'm the one who filed https://bugs.python.org/issue31778, but I'm not a Python contributor, so presumably someone else needs to review this too.
| right = _convert(node.right) | ||
| if isinstance(left, _NUM_TYPES) and isinstance(right, _NUM_TYPES): | ||
| left = _convert_signed_num(node.left) | ||
| right = _convert_num(node.right) |
There was a problem hiding this comment.
Perhaps it would be useful to add to the test assertRaises(ValueError, ast.literal_eval, '3 + (0 + 2j)') to catch unintended behavior changes to _convert_num in future edits.
| self.assertEqual(ast.literal_eval('+6'), 6) | ||
| self.assertEqual(ast.literal_eval('-6'), -6) | ||
| self.assertEqual(ast.literal_eval('-6j+3'), 3-6j) | ||
| self.assertEqual(ast.literal_eval('3.25'), 3.25) |
There was a problem hiding this comment.
Perhaps it would also be useful to assertRaises(ValueError for an expression such as 1j+2j or 1+2j+3j.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition and subtraction of arbitrary numbers no longer allowed.
https://bugs.python.org/issue31778