Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4().#4079
Merged
abalkin merged 4 commits intopython:masterfrom Oct 24, 2017
Merged
Closes bpo-28292: Implemented Calendar.itermonthdays3() and itermonthdays4().#4079abalkin merged 4 commits intopython:masterfrom
abalkin merged 4 commits intopython:masterfrom
Conversation
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but needs a documentation.
| for i, d in enumerate(self.itermonthdays(year, month), self.firstweekday): | ||
| yield d, i % 7 | ||
|
|
||
| def itermonthdays3(self, year, month): |
Member
There was a problem hiding this comment.
The order of methods: itermonthdays2, itermonthdays3, itermonthdays4, itermonthdays looks slightly inconsistent.
serhiy-storchaka
approved these changes
Oct 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar.itermonthdates() will now consistently raise an exception when a date falls outside of the 0001-01-01 through 9999-12-31 range. To support applications that cannot tolerate such exceptions, the new methods itermonthdays3() and itermonthdays4() are added. The new methods return tuples and are not restricted by the range supported by datetime.date.
Thanks @serhiy-storchaka for suggesting the itermonthdays4() method and for the review.
https://bugs.python.org/issue28292