[3.6] bpo-31926: fix missing *_METHODDEF statements by argument clinic (GH-4230)#4253
Merged
vstinner merged 1 commit intopython:3.6from Nov 3, 2017
Merged
Conversation
pythonGH-4230) When a single .c file contains several functions and/or methods with the same name, a safety _METHODDEF GH-define statement is generated only for one of them. This fixes the bug by using the full name of the function to avoid duplicates rather than just the name.. (cherry picked from commit 4f57409)
serhiy-storchaka
approved these changes
Nov 3, 2017
Contributor
Author
|
Would it be okay if I merged this myself? |
Member
|
Thank you for the backport, LGTM and @serhiy-storchaka approved, so I merged it.
Oh, I merged this change before I noticed that you are a core developer and so can merge your own change, sorry. I will let you click you on [Merge] next time ;-) At least, it doesn't change anything to the ownership, you remain the author of the commit ;-) |
Contributor
Author
|
Thanks @Haypo! No worries about the merge, I'm just trying to learn the ropes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31926