Skip to content

bpo-31338: Mention that Py_UNREACHABLE was added in 3.7#4337

Merged
serhiy-storchaka merged 1 commit intopython:masterfrom
encukou:docs-unreachable
Nov 8, 2017
Merged

bpo-31338: Mention that Py_UNREACHABLE was added in 3.7#4337
serhiy-storchaka merged 1 commit intopython:masterfrom
encukou:docs-unreachable

Conversation

@encukou
Copy link
Copy Markdown
Member

@encukou encukou commented Nov 8, 2017

The macro was added for bpo-31338 in commit b2e5794.

I think this note is trivial enough to not need its own issue or NEWS entry.

https://bugs.python.org/issue31338

The macro was added for bpo-31338 in commit b2e5794
@serhiy-storchaka serhiy-storchaka changed the title Docs: Mention that Py_UNREACHABLE was added in 3.7 bpo-31338: Mention that Py_UNREACHABLE was added in 3.7 Nov 8, 2017
@serhiy-storchaka serhiy-storchaka added the docs Documentation in the Doc dir label Nov 8, 2017
@serhiy-storchaka serhiy-storchaka merged commit 8bf288e into python:master Nov 8, 2017
@serhiy-storchaka
Copy link
Copy Markdown
Member

Thanks @encukou.

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a follow-up PR: PR #4339, to add other missing versionadded markups on C macros.

Comment thread Doc/c-api/intro.rst

.. c:macro:: Py_ABS(x)

Return the absolute value of ``x``.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you add versionadded, you may also document:

  • Py_MIN, Py_MAX, Py_ABS: Python 3.3
  • Py_STRINGIFY: Python 3.4
  • Py_MEMBER_SIZE: Python 3.6

embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
@encukou encukou deleted the docs-unreachable branch April 20, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants