Silence error output in test_concurrent_futures (bpo-21423)#4347
Merged
pitrou merged 3 commits intopython:masterfrom Nov 9, 2017
Merged
Silence error output in test_concurrent_futures (bpo-21423)#4347pitrou merged 3 commits intopython:masterfrom
pitrou merged 3 commits intopython:masterfrom
Conversation
serhiy-storchaka
previously approved these changes
Nov 9, 2017
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Excellent! I'm not well known with logging, but it seems to me that this fixes the issue in right way.
| while True: | ||
| try: | ||
| output.append(self.log_queue.get_nowait().getMessage()) | ||
| except queue.Empty: |
Member
There was a problem hiding this comment.
You could catch an exception outside of the loop.
But tests are failed on Windows. :(
Member
Author
|
I've fixed the tests on Windows now. |
serhiy-storchaka
approved these changes
Nov 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue21423