Skip to content

bpo-32066: Support pathlib.Path in create_unix_connection; sock arg should be optional#4447

Merged
1st1 merged 2 commits intopython:masterfrom
1st1:fix_unix_con
Nov 20, 2017
Merged

bpo-32066: Support pathlib.Path in create_unix_connection; sock arg should be optional#4447
1st1 merged 2 commits intopython:masterfrom
1st1:fix_unix_con

Conversation

@1st1
Copy link
Copy Markdown
Member

@1st1 1st1 commented Nov 17, 2017 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov November 17, 2017 23:30
@1st1 1st1 changed the title Support pathlib.Path in create_unix_connection; sock arg should be optional bpo-32066: Support pathlib.Path in create_unix_connection; sock arg should be optional Nov 17, 2017
asvetlov
asvetlov requested changes Nov 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but asyncio-eventloop.rst should reflect accepted pathlib.Path parameter for create_unix_connection and create_unix_server IMHO

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 18, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@1st1
Copy link
Copy Markdown
Member Author

1st1 commented Nov 18, 2017

I have made the requested changes; please review again

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 18, 2017

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@1st1 1st1 merged commit 423fd36 into python:master Nov 20, 2017
@1st1 1st1 deleted the fix_unix_con branch November 20, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@1st1 @bedevere-bot @asvetlov @the-knights-who-say-ni