bpo-32107: Remove the check of the multicast bit in test_uuid.#4572
bpo-32107: Remove the check of the multicast bit in test_uuid.#4572serhiy-storchaka wants to merge 1 commit intopython:masterfrom
Conversation
While it is required that the multicast bit (1<<40) should be set in random generated addresses, there is no requirement that it should be cleared in addresses obtained from network cards.
|
I don't really want to land this in isolation of #4494. I see what you're saying now that the comment was wrong, but it was also really confusing because it never mentioned the multicast bit. So I had to infer what the intention was, and that led me down the path of #4494, which I still think is a good change to make. The question is whether it's enough to ensure that the MAC address is within the 48-bit range, as that's the only test you have left in this branch. My branch also tests that the returned MAC is a universally administered MAC, which can't succeed on Travis because Travis has no universally administered MACs, as the comments on that PR explains. |
|
When you're done making the requested changes, leave the comment: |
…torchaka/cpython into test_uuid This merges the relevant bits of python#4572 and should be considered instead of that PR.
|
@serhiy-storchaka - I've merged this branch into #4494 and tweaked it just a bit, and added comments. Can we please approve and land #4494 instead? |
While it is required that the multicast bit (1<<40) should be set in random generated addresses, there is no requirement that it should be cleared in addresses obtained from network cards.
https://bugs.python.org/issue32107