bpo-31245: asyncio: Fix typo, isistance => isinstance#4594
Merged
vstinner merged 1 commit intopython:masterfrom Nov 27, 2017
vstinner:asyncio_typo
Merged
bpo-31245: asyncio: Fix typo, isistance => isinstance#4594vstinner merged 1 commit intopython:masterfrom vstinner:asyncio_typo
vstinner merged 1 commit intopython:masterfrom
vstinner:asyncio_typo
Conversation
Member
Author
|
Typo spotted while using pyflakes on the stdlib. |
1st1
approved these changes
Nov 27, 2017
Member
Author
|
cc @ovv |
Member
|
Ideally need a regression test to trigger a NameError in current master branch. |
Member
Author
Sorry, I'm too lazy to do that. I only wanted to fix an obvious typo fixed in a recent commit ;-) |
Contributor
|
My bad, I should have catch that. Thanks @vstinner |
Member
Author
No problem. If you want, you may write an unit test which tests also this code path. Since the bug was not catched by the tests, it seems like we miss some tests. Sorry, I didn't look at https://bugs.python.org/issue31245 |
ovv
pushed a commit
to Eyepea/cpython
that referenced
this pull request
Dec 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31245