Skip to content

Improve ensurepip's --help#4686

Merged
encukou merged 2 commits intopython:masterfrom
mineo:ensurepip-help
May 30, 2018
Merged

Improve ensurepip's --help#4686
encukou merged 2 commits intopython:masterfrom
mineo:ensurepip-help

Conversation

@mineo
Copy link
Copy Markdown
Contributor

@mineo mineo commented Dec 3, 2017

Commit 1:

Add a space to ensurepip's --altinstall option

This changes the output from:

↪ python -m ensurepip --help
[...]
  --altinstall   Make an alternate install, installing only the X.Y
                 versionedscripts (Default: pipX, pipX.Y, easy_install-X.Y)

to:

↪ ./python -m ensurepip --help
[...]
  --altinstall   Make an alternate install, installing only the X.Y versioned
                 scripts (Default: pipX, pipX.Y, easy_install-X.Y)

Commit 2:

Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help.

mineo added 2 commits December 3, 2017 13:42
This changes the output from:

↪ python -m ensurepip --help
[...]
  --altinstall   Make an alternate install, installing only the X.Y
                 versionedscripts (Default: pipX, pipX.Y, easy_install-X.Y)

to:

↪ ./python -m ensurepip --help
[...]
  --altinstall   Make an alternate install, installing only the X.Y versioned
                 scripts (Default: pipX, pipX.Y, easy_install-X.Y)
This makes --help for all optional arguments consistent and also makes it
consistent with pip --help.
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@encukou
Copy link
Copy Markdown
Member

encukou commented May 16, 2018

@mineo, in order to accept a change to CPython, we need formal approval that we can share your work with the world.
Could you please follow the steps at https://devguide.python.org/pullrequest/#cla ?
Sorry for the hurdle.

@mineo
Copy link
Copy Markdown
Contributor Author

mineo commented May 29, 2018

@encukou No problem - I was hoping to maybe stay under the CLA radar for such a small contribution :-), but I've now filled out the CLA and have the correct flag on b.p.o: https://bugs.python.org/user18307.

@encukou
Copy link
Copy Markdown
Member

encukou commented May 30, 2018

Thanks for doing that!
I think this doesn't need an issue/NEWS, and should to be backported to all maintained versions.
I'm still new to this, so I'll ask a more experienced core dev to check those labels before merging, in case I missed anything.

@encukou encukou merged commit e9537ad into python:master May 30, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @mineo for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-7238 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2018
* Add a space to ensurepip's --altinstall option
* Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help.
(cherry picked from commit e9537ad)

Co-authored-by: Wieland Hoffmann <[email protected]>
@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, @mineo and @encukou, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e9537ad6a128924dd610bea2268065500c174181 2.7

@bedevere-bot
Copy link
Copy Markdown

GH-7239 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2018
* Add a space to ensurepip's --altinstall option
* Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help.
(cherry picked from commit e9537ad)

Co-authored-by: Wieland Hoffmann <[email protected]>
encukou pushed a commit that referenced this pull request May 30, 2018
* Add a space to ensurepip's --altinstall option
* Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help..
(cherry picked from commit e9537ad)

Co-authored-by: Wieland Hoffmann <[email protected]>
@bedevere-bot
Copy link
Copy Markdown

GH-7240 is a backport of this pull request to the 2.7 branch.

encukou pushed a commit that referenced this pull request May 30, 2018
* Add a space to ensurepip's --altinstall option
* Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help.
(cherry picked from commit e9537ad)

Co-authored-by: Wieland Hoffmann <[email protected]>
encukou added a commit that referenced this pull request May 30, 2018
* Add a space to ensurepip's --altinstall option
* Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help..
(cherry picked from commit e9537ad)

Co-authored-by: Wieland Hoffmann <[email protected]>
encukou pushed a commit that referenced this pull request May 30, 2018
* Add a space to ensurepip's --altinstall option
* Add periods to the arguments of ensurepip that didn't have it

This makes --help for all optional arguments consistent and also makes it
consistent with pip --help.
(cherry picked from commit e9537ad)

Co-authored-by: Wieland Hoffmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants